fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email )
Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ......................................................................
netdev: netdev_mnl_set_mtu(): drop unneeded variables
Setting an MTU via `RTM_NEWLINK` does not require `ifi_flags`/ `ifi_change`, so we don't really need to set these fields.
Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 --- M src/core/netdev.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/42406/1
diff --git a/src/core/netdev.c b/src/core/netdev.c index 7e5a409..e63bbc3 100644 --- a/src/core/netdev.c +++ b/src/core/netdev.c @@ -541,8 +541,6 @@ char buf[MNL_SOCKET_BUFFER_SIZE]; struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct ifinfomsg *ifm; - unsigned int change = 0; - unsigned int flags = 0;
nlh->nlmsg_type = RTM_NEWLINK; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; @@ -550,8 +548,6 @@
ifm = mnl_nlmsg_put_extra_header(nlh, sizeof(*ifm)); ifm->ifi_family = AF_UNSPEC; - ifm->ifi_change = change; - ifm->ifi_flags = flags; ifm->ifi_index = if_index;
mnl_attr_put_u32(nlh, IFLA_MTU, mtu);