Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/38884?usp=email )
Change subject: pySim-shell: change Prompt character to "#" after
"verify_adm"
......................................................................
Patch Set 3:
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/38884/comment/32ee3710_eaa75e5c?usp=em… :
PS1, Line 301:
Your gut feeling is correct. There is/was indeed a
problem with equip. I have fixed this now. […]
(My browser setup died, the last
paragraph should be something entirely different)
I wanted to say that I have moved the adm_verified state into the rs object. Since we
normally call the reset method of this object, the state can be reset by that method much
safer. Also we get a new rs object when we call init_card.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38884?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I957b9df7b5069b6fce5bf958c94e8ffda833c77f
Gerrit-Change-Number: 38884
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Nov 2024 14:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>