Attention is currently required from: daniel, laforge, pespin.

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email )

Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ......................................................................

Patch Set 3:

(3 comments)

This change is ready for review.

Patchset:

PS1:

WIP, see comment on write callback

https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/c820b4d9_2ce6f4a0/

File src/core/gsmtap_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/fd6f571f_2548a01d PS2, Line 441: }

msg doesn't need to be freed here?

Ah yes, thanks. The case `OSMO_FD_READ` doesn't free the msgb, unlike `OSMO_FD_WRITE`, I was only looking at the latter.

https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/9c2cf47b_92c44199 PS2, Line 493: * \param[in] osmo_io_mode Register \ref osmo_wqueue (1) or not (0)

Don't change the API param name, it's not really needed.

Done