Attention is currently required from: daniel, laforge, pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #1:

    WIP, see comment on write callback

    https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/c820b4d9_2ce6f4a0/

• File src/core/gsmtap_util.c:

  • Patch Set #2, Line 441: }

    msg doesn't need to be freed here?

    Ah yes, thanks. The case `OSMO_FD_READ` doesn't free the msgb, unlike `OSMO_FD_WRITE`, I was only looking at the latter.

  • Patch Set #2, Line 493: * \param[in] osmo_io_mode Register \ref osmo_wqueue (1) or not (0)

    Don't change the API param name, it's not really needed.

    Done

To view, visit change 34743. To unsubscribe, or for help writing mail filters, visit settings.