neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27902 ) Change subject: emerg call deny: fix RR release cause ...................................................................... emerg call deny: fix RR release cause So far the we indicated pre-emption in the release cause of denying an emergency setup, instead indicate protocol error. When emergency calls are disallowed, it is not pre-emption (making room for an emergency call) but a protocol error (MS asks for emergency call when the network does not allow it). Related: OS#5534 Change-Id: Ia195621165cb7bbe33e6c2e915abc42ab16a2a4f --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index 02bb996..e2bcaa9 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -1062,7 +1062,7 @@ if (msg->lchan->ts->trx->bts->si_common.rach_control.t2 & 0x4) { LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP although EMERGENCY CALLS" " are not allowed in sysinfo (cfg: network / bts / rach emergency call allowed 0)\n"); - lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL, + lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PROT_ERROR_UNSPC, gscon_last_eutran_plmn(msg->lchan->conn)); break; } @@ -1070,7 +1070,7 @@ LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are" " denied on MSC %d (cfg: msc %d / allow-emergency deny)\n", conn->sccp.msc->nr, conn->sccp.msc->nr); - lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL, + lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PROT_ERROR_UNSPC, gscon_last_eutran_plmn(msg->lchan->conn)); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia195621165cb7bbe33e6c2e915abc42ab16a2a4f Gerrit-Change-Number: 27902 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged