Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 )

Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ......................................................................

Patch Set 2: Code-Review+2

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/07530ad4_e0923... PS2, Line 10: actually support PPS on CD for USB-CDC devices :( I guess this is due to the fact that one generally assumes USB devices with no real CPU interrupt (just the slow / 1ms resolution USB serialized interrupt packet) have too much jitter for proper PPS.

Patchset:

PS2:

I don't agree with the linter for the remaining one ... […]

well, it is the kernel coding style to have "} else {". The linter is correct to flag it - but it of course doesn't know that this is not an osmocom CNI project and hence those rules don't apply.