laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38294?usp=email )
Change subject: s1ap_proxy: clarify a logging statement, reduce verbosity ......................................................................
s1ap_proxy: clarify a logging statement, reduce verbosity
Logging all S1AP PDUs at INFO is way to verbose, use DEBUG. Clarify that this is the Rx (receive) direction.
Change-Id: I325758c7fb632dc67d0d9cf1f2e58ca337e7a744 --- M src/s1ap_proxy.erl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved
diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 1df1518..c985601 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -82,7 +82,7 @@ handle_pdu(Data, S) when is_binary(Data) -> case decode_pdu(Data) of {ok, Pdu} -> - ?LOG_INFO("S1AP PDU: ~p", [Pdu]), + ?LOG_DEBUG("Rx S1AP PDU: ~p", [Pdu]), handle_pdu(Data, Pdu, S); {error, {asn1, Error}} -> ?LOG_ERROR("S1AP PDU decoding failed: ~p", [Error]),