Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900?usp=email )
Change subject: s2b: answer echo requests ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37900/comment/0013e146_e2250... : PS1, Line 520: IEs = [#v2_recovery{restart_counter = RCnt}], This looks wrong. The RestartCounter we send has nothing to do with the one we receive. Ideally we should read it at startup (or set to 0 if unable to read it), and increment and write it back after startup finishes.
For now I guess it's good enough to send a "0" or to send a timestamp?
-
pespin