pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40549?usp=email ) Change subject: xua_asp_fsm: Drop code branch never called in xUA ASP ...................................................................... xua_asp_fsm: Drop code branch never called in xUA ASP ACTIVE state is only entered (xua_asp_fsm_active_onenter) from INACTIVE state; it cannot be entered from DOWN state. Hence, went went_up would always be false and the code never executed. This code is indeed not used since we already make sure we start BEAT procedure when entering INACTIVE state from DOWN state, and only disable it when we go back to DOWN state. Fixes: ce6b537fcc4c52a90d8072714ce41158524b3008 Change-Id: Ic0b8b4fbe31ab2e5206a4f4c7907868f20d2ef10 --- M src/xua_asp_fsm.c 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index 26f3a78..86d86b7 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -695,12 +695,6 @@ { struct xua_asp_fsm_priv *xafp = fi->priv; struct osmo_ss7_asp *asp = xafp->asp; - bool went_up = (prev_state == XUA_ASP_S_DOWN); - - if (went_up) { - /* Now we are done with IPA handshake, Start Hearbeat Procedure, T(beat): */ - xua_t_beat_send(fi); - } dispatch_to_all_as(fi, XUA_ASPAS_ASP_ACTIVE_IND, asp); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0b8b4fbe31ab2e5206a4f4c7907868f20d2ef10 Gerrit-Change-Number: 40549 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>