Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35914?usp=email )
Change subject: gsm: add TCH block/lchan definitions for CSD ......................................................................
Patch Set 2:
(1 comment)
File src/gsm/gsm44021.c:
https://gerrit.osmocom.org/c/libosmocore/+/35914/comment/10722539_a12b4204 PS2, Line 30: if 0 : [GSM48_CMODE_DATA_14k5] = { : /* TCH/F14.4: 290 bits every 20 ms (14.5 kbit/s) */ : .fr = { .num_frames = 1, .num_bits = 290 }, : }, : #endif
i'm not quite sure I like that kind of commented-out data structure in libosmocore. […]
The problem here is that I was not sure whether this definition is correct, so this is why I left this entry commented out. I just checked 3GPP TS 44.021, section 10.3.2, and found out that a radio block for TCH/F14.4 consists of 8 modified V.110 frames (36 bits each) plus the `M1`/`M2` bits. I'll update the patch.
-
fixeria