Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007 )
Change subject: chapters/logging: Expand documentation on GSMTAP logging
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File common/chapters/logging.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007/comment/bca2a68a_0382…
PS2, Line 247: open the socket at the GSMTAP port and discard anything arriving at it.
Maybe also explain that in remote IP addresses in the
local system we try to open the port to avoid […]
that depends on the code in
question (whether it calls gsmtap*add_sink). Not sure we do that for logging. Which is the
case for vty-based logging, but not for a program that might call
log_target_create_gsmtap() directly, without the VTY (some small utility without VTY might
do that).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9d7a15fd81bb0f3bc89b97ebfd35e9efc48c94e2
Gerrit-Change-Number: 32007
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Mar 2023 08:55:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment