Attention is currently required from: daniel, osmith, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36590?usp=email )
Change subject: ttcn3-hnbgw: Apply latest changes to 'with-pfcp' scenario ......................................................................
Patch Set 1:
(1 comment)
File ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg:
https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/2dd6d0cf_bfea... PS1, Line 120: +
this "+" seems to be a copy paste bug -- let me guess, you haven't actually tested this patch...
(then again not so trivial to test docker-playground patches, at first thought this was osmo-ttcn3-hacks)
This seems to duplicate hnbgw.cfg item 'timer X31' -- IMHO we should have one fixed config in osmo-hnbgw.cfg, or only ttcn3 code that adjusts config via VTY. This here says it keeps a value in sync with a .cfg file, so is it being duplicated? I'd favor avoiding that duplication... fine if it's too late / unrelated