Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email )
Change subject: asterisk: Test initial IMS REGISTER timeout ......................................................................
Patch Set 2:
(3 comments)
File asterisk/Asterisk_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/1eb85011_ef9a1... PS2, Line 51: /* Current default by pjproject (timeout_timer_val) to 32s, and not changed by Asterisk */
the comment doesn't seem to be a valid sentence?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/c0857476_ca570... PS2, Line 52: integer mp_volte_ims_outbound_register_timeout := 32;
(wouldn't a float make more sense, since titan handles all timers in float? does it have to be limit […]
There's no need to go subsecond here, since it matches a full-second value in Asterisk.
File asterisk/IMS_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/8ac451c2_dc04c... PS2, Line 211: t_guard := 60.0,
in some test suites we can set individual test timeouts to a larger value by f_init(t_guard := 60. […]
Yes, I think 60 seconds is actually a usual default we use in most testsuites, so I simply increase it here.
-
pespin