Attention is currently required from: pespin, fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406 )
Change subject: fix coding of Network Instance IE
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/cbfe6075_bc3ec1bb
PS1, Line 13: These qualify for moving to libosmocore utils
SO IIUC the code that neels proposes here is not
needed since the same is already implemented in lib […]
Done
Patchset:
PS1:
oh meh ... using apn.c means to add libosmogsm as a
dependency, so far only had libosmocore. […]
Done
File src/libosmo-pfcp/pfcp_ies_custom.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/7006b67d_c28ca995
PS1, Line 86: static int strncpy_buf(char *buf, size_t buflen, const char *src, size_t
len)
len is "srclen"?
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I9d67464ef0f92b0512cfd6e48d203f8828a82a19
Gerrit-Change-Number: 30406
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Dec 2022 03:20:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment