Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email ) Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits ...................................................................... Patch Set 1: (2 comments) File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/75231a20_18bb… : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 What's the point of adding testcase parameters? I am not sure if there is a way to pass any parameters when executing a testcase... https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/c969fc33_1570… : PS1, Line 347: setverdict(fail, "Received unexpected NS-ALIVE ACK"); As the name suggests, `ax_rx_fail_on_any_ns()` already does `setverdict(fail, ...)` internally, so this additional `setverdict()` is redundant. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f Gerrit-Change-Number: 39011 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Dec 2024 11:07:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No