Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits ......................................................................
Patch Set 1:
(2 comments)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/75231a20_18bb6... : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0 What's the point of adding testcase parameters? I am not sure if there is a way to pass any parameters when executing a testcase...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/c969fc33_15705... : PS1, Line 347: setverdict(fail, "Received unexpected NS-ALIVE ACK"); As the name suggests, `ax_rx_fail_on_any_ns()` already does `setverdict(fail, ...)` internally, so this additional `setverdict()` is redundant.