Attention is currently required from: osmith.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660 )
Change subject: Add command-line options
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
just noticed this very old draft comment of mine, maybe it is still relevant
File src/osmo-bsc-nat/main.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660/comment/e64cbc72_4fd9af23
PS2, Line 65: printf(" -V, --version show version number and
exit\n");
we usually also have some more options:
-D --daemonize Fork the process into a background daemon
I have never once used this, but it exists in most osmo programs.
And:
printf("\nVTY reference generation:\n");
printf(" --vty-ref-mode MODE VTY reference generation mode (e.g.
'expert').\n");
printf(" --vty-ref-xml Generate the VTY reference XML output
and exit.\n");
I assume osmo-bsc-nat has a VTY? So then we definitely want to (be able to) auto generate
a VTY reference. e.g. see handle_long_options() in msc_main.c.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I41bca9e1b88bb130870d078ed3f499e39e0bf5d3
Gerrit-Change-Number: 26660
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Mar 2022 02:45:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment