tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 )

Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/975b57c4_7e1de... PS2, Line 10: actually support PPS on CD for USB-CDC devices :(

I guess this is due to the fact that one generally assumes USB devices with no real CPU interrupt (j […]

No, because it's supported on FTDI or PL2023 USB->Serial for instance. It's just that no one bother to implement it for USB CDC ACM devices.

(And yes, the jitter / precision isn't great, but over long periods it's not all that bad)

Patchset:

PS2:

well, it is the kernel coding style to have "} else {". […]

Yeah I know and in general I agree, but some times depending on surrounding code, it just doesn't "look" nice and makes it harder to read and so I don't adhere strictly. Just my 2ct anyway.