Attention is currently required from: Hoernchen, Timur Davydov, fixeria, osmith, pespin.

laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )

Change subject: build: add --disable-multi-arfcn configure option ......................................................................

Patch Set 6: Code-Review+1

(4 comments)

File Transceiver52M/arch/common/Makefile.am:

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/7c96afc0_07c184e0?usp=... : PS1, Line 16: NOT_HAVE_EMSCRIPTEN

Agreed, thanks. I now use HAVE_EMSCRIPTEN directly and removed NOT_HAVE_EMSCRIPTEN.

Done

File configure.ac:

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c5c511f2_715a7743?usp=... : PS3, Line 82: AC_DISABLE_SHARED dnl don't build shared libraries (emscripten)

Sounds good. Once this is merged, I'll rebase my branch accordingly.

Done

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/e380fd41_7a698f65?usp=... : PS3, Line 306: PKG_CHECK_MODULES(LIBUSB, libusb-1.0)

Sounds good. Once this is merged, I'll rebase my branch accordingly.

Done

https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/39c692fa_c7673805?usp=... : PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f)

Yes, that makes sense. […]

Done