Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31304 )
Change subject: Includes: Remove enum defs, instead include them ......................................................................
Patch Set 4:
(1 comment)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31304/comment/61ce5f3b_e8d5d003 PS1, Line 654: enum gprs_cs {
This enum pretty much already exists in `libosmocore/include/osmocom/gsm/protocol/gsm_44_060.h`. […]
IIUC the one under gsm_44_06.h is used to describe internal data structures / fields, while the other describes bits in a bitmask used in a field sent over a specific protocol (ipaccess Abis OML/RSL). So the purpose is different and hence the values of each one may be different. Can you check the use of those and see if I'm correct?
-
pespin