Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 )

Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1:

looking at this again, the intent of the code is quite clear: Stop the loop if there just was a new […]

See my other comment.

File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/27777/comment/bbfdf9ff_b0b3086c PS1, Line 462: if (chan_state->codec[i] == cmr_codec) To me it reads as: if the decoded CMR value is present in the list of allowed codec modes, then we disable the loop below. Of course this is always the case. Also note that this is the Downlink path, not Uplink.