Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28039 )
Change subject: Update current NM object state before signalling S_NM_STATECHG
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I suggest adding comment(s) to the respective signal handlers stating that the NM object state has already been changed by the signal emitter and additionally rename s/S_NM_STATECHG/S_NM_STATECHGED/ to clarify things further.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28039
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib46234e3f3e446e866d27b0dfee65edf4af4d2ba
Gerrit-Change-Number: 28039
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 10 May 2022 09:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment