Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email )
Change subject: Make ch9 usb tests work ......................................................................
Patch Set 1:
(12 comments)
File sysmoOCTSIM/main.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/7b766c55_347... : PS1, Line 594: // // if (i == 2 && usb_d_ep_get_status(/*_ccid_df_funcd.func_ep_out*/ 2, 0) == USB_BUSY) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/66ec40b7_72e... : PS1, Line 595: // // continue; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/2c27648b_683... : PS1, Line 597: // msgb_reset(cur_msg); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/1865307b_7d0... : PS1, Line 598: // llist_add_tail_at(&cur_msg->list, &g_ccid_s.free_q); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/5f76c7d4_5dc... : PS1, Line 599: // OSMO_ASSERT(msg->list.next != LLIST_POISON1) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/a2eddd8b_c0b... : PS1, Line 600: // OSMO_ASSERT(msg->list.next->next != LLIST_POISON1) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/b33ffb5f_ae6... : PS1, Line 601: // OSMO_ASSERT(msg->list.prev != LLIST_POISON2) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/67776b4b_a60... : PS1, Line 602: // OSMO_ASSERT(msg->list.prev->prev != LLIST_POISON2) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/90c68c14_709... : PS1, Line 603: // cur_epq->in_progress = NULL; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/c0cba701_37b... : PS1, Line 610: // ; please, no space before tabs
File sysmoOCTSIM/usb/class/ccid/device/ccid_df.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/ba22d302_edf... : PS1, Line 228: // return ERR_NOT_FOUND; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21989): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/d1ce62e9_222... : PS1, Line 242: // return ERR_NONE; please, no space before tabs