Attention is currently required from: kirr.
laforge has posted comments on this change by kirr. (
https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email )
Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote()
function
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I would have turned it into a property - or, if we really print it a lot, compute+store
the string once and return that rather than format-printing it ecah time?
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe
Gerrit-Change-Number: 40046
Gerrit-PatchSet: 1
Gerrit-Owner: kirr <kirr(a)nexedi.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: kirr <kirr(a)nexedi.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 09:55:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes