Attention is currently required from: falconia, fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email )
Change subject: codec: add osmo_hr_sid_classify()
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Not critical, but I would appreciate if we could introduce a unit test with at least a few sample input data. This of course doesn't only apply to this new function but really to all of those classifiers.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5f4eb65379646125b966cf182775b6e9348900bd
Gerrit-Change-Number: 37558
Gerrit-PatchSet: 3
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: osmith
osmith@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 30 Jul 2024 09:35:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment