Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958?usp=email )
Change subject: s1gw: Initial StatsD support ......................................................................
Patch Set 3:
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958/comment/0996a28b_a4f4a... : PS2, Line 112: f_new_ConnHdlrPars
Because one needs to pass mp_statsd_prefix everytime, and beter doing it once here than in every tes […]
Ok, I understand the problem now. Fine merging it then, but I would like to understand the idea behind this.
So you want to allow each `ConnHdlr` to have a custom statsd prefix and you let the `test_CT` to assign prefixes to `ConnHdlr` instances it spawns. But so far you're always passing `mp_statsd_prefix` for all `ConnHdlr` instances. And AFAICS, the `statsd_prefix` field is not used in the code (yet?). What's your plan? What kind of format for the prefixes do you have in mind?
-
fixeria