Attention is currently required from: pespin, dexter.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32733 )

Change subject: paging: parse PCUIF data indication outside of paging.c ......................................................................

Patch Set 8:

(2 comments)

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/d97c32a3_0a628124 PS8, Line 679: osmo_strlcpy(&imsi[0], (char *)data_req->data, sizeof(imsi));

OSMO_STRLCPY_ARRAY

Ack, I forgot about this macro...

https://gerrit.osmocom.org/c/osmo-bts/+/32733/comment/7aa29322_2c15b7e6 PS8, Line 682: confirm = true;

I believe this is going to fail, I don't see confirm being defined.

Looks like it's something from a follow-up patch.