[M] Change in pysim[master]: personalization: refactor ConfigurableParameter, Iccid, Imsi - gerrit-log

7 Jan 2026


      Attention is currently required from: dexter, fixeria, neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39742/comment/e0edc817_9132f588?usp=ema... :
PS13, Line 50:     r"""Base class representing a part of the eSIM profile that is configurable during the
I still don't understand why an abstract class is not inheriting from abc.ABC (especially as it has abc.abtstractmethod, I've never seen the latter without the former).  I'd appreciate if my curiosity is satisfied, but this is not a blocker for getting the patch merged.
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8
Gerrit-Change-Number: 39742
Gerrit-PatchSet: 13
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 07 Jan 2026 12:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes