Attention is currently required from: laforge, fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
......................................................................
Patch Set 5:
(1 comment)
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/afe10b67_1d9131b2
PS5, Line 1105: #ifdef ENABLE_ERICSSON_RBS
Agreeing with Pau here, maybe make the BTS type configurable somehow? Or even better: make BSC/BTS i […]
I have eliminated the need for compile time IF here now but I still wondering, we have different phy implementations for litecell, sysmo-bts and oc2g. As far as I am aware its a compile-time distinction there as well.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31145
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 5
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 06 Feb 2023 12:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
dexter