Attention is currently required from: fixeria.

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email )

Change subject: trau_rtp_conv: add support for HRv1 in 8k format ......................................................................

Patch Set 2:

(1 comment)

File src/trau/trau_rtp_conv.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/37287/comment/bc035ff5_01447673 PS2, Line 669: tf->xc_bits[0] = 0;

Shorter != more readable in this case, I would argue. […]

I tried doing this:

``` if (osmo_hr_check_sid(data, data_len)) tf->xc_bits = {0, 0, 0, 1, 0, 0}; else tf->xc_bits = {0, 0, 0, 0, 0, 1}; ```

but the compiler is barfing at me:

``` trau/trau_rtp_conv.c:669:17: error: expected expression before '{' token tf->xc_bits = {0, 0, 0, 1, 0, 0}; ```

I am afraid this old hag of K&R C and Ancient UNIX upbringing is not up to speed with modern C tricks. I'll put my original code back in for the next patch iteration, and leave it there until/unless someone shows me a way to do what I was trying above.