pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27223 ) Change subject: mgcp_codec: do not differentiate between oa and bwe when comparing codec ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I have the feeling this patch is going in the wrong direction. or maybe it's that other stuff is missing in osmo-mgw. See a sample of an SDP: """ MDCX 1817 rtpbridge/1@mgw MGCP 1.0 C: 10a I: 1654DE0D M: sendrecv v=0 o=- 10a 23 IN IP4 127.0.0.1 s=- c=IN IP4 192.168.33.2 t=0 0 m=audio 17076 RTP/AVP 98 a=fmtp:98 octet-align=1 a=rtpmap:98 AMR/8000/1 a=ptime:20 """ So IIUC that means: Hey I have a peer available on 192.168.33.2:17076 which wants to talk AMR OA using Payload Type 98. The peer could also announce support for AMR BE in a different Payload Type if he wanted: """ a=fmtp:99 octet-align=0 a=rtpmap:99 AMR/8000/1 """ So my understanding is that octet_aligned information should be checked when picking up the proper Payload Type. With your patch, IIUC, you would pick the first one, regardless of the AMR OA/BE support announced by the peer? So ideally you should first check if the BE/OA info matches,and if not, pick one even if it doesn't match, and do "transcoding" BE<->OA. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I64731570c287a75d39c79c10e1bc09a37bdd54d6 Gerrit-Change-Number: 27223 Gerrit-PatchSet: 4 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 16 Feb 2022 17:13:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment