Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ......................................................................
ipa: Add osmo_ipa_ka_fsm_inst APIs
This new object and its APIs are meant to replace ipa_keepalive_fsm_* APIs from libosmo-abis, because: 1- libosmo-abis is not the proper place to have IPA generic code, since other protocols than Abis also use IPA underneath. 2- the existing API in libosmo-abis is actually a set of 3 interfaces, 2 of which rely on ipa_client_conn and ipa_server_conn, which are provided by libosmo-abis itself and which will eventually be deprecated. Hence, only the "generic" one is actually reimplemented here, so it is backend agnsotic.
A notable difference from the FSM implementation in libosmo-abis is that this fsm instnace object doesn't terminate itself, but leaves the decision to the user, in order to allow for more flexibility during object destruction.
Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd --- M TODO-RELEASE M include/osmocom/netif/ipa.h M src/Makefile.am A src/ipa_keepalive.c 4 files changed, 379 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/39035/4