Attention is currently required from: neels, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28286 )
Change subject: add libosmo-gtlv, moved from osmo-upf.git
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
- I thought it would be quick, but i've already
spent hours on that, it is frustrating. […]
I'm not worried about library naming
with or without dash, but src/{gsm,sim,...,gtlv} should not suddenly be src/libosmo-gtlv.
The problems you are seeing are more or less all attributed to the fact that the related
code was developed outside of libosmocore (and a lot of stuff happened before gerrit in
branches or separate repo) to begin with. So if the questions had been clarified early
on, it would have been possible to avoid.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28286
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71
Gerrit-Change-Number: 28286
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Jun 2022 13:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment