Attention is currently required from: daniel, laforge, neels.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email )

Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ......................................................................

Patch Set 5:

(3 comments)

File include/osmocom/mgcp/mgcp_protocol.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/8e66f61b_c4c8050b?usp=... : PS4, Line 7: #define MGCP_PARSE_HDR_PARS_OSMUX_CID_WILDCARD (-1)

i disagree with that position. […]

Neels, what are you talking about? You say you want me to add an enum with one or two fields and let aside the other 2^16 values? Or you want me to add 2^16 values to the enum?

enums are meant for closed sets of values, not to cover int ranges with specific 2 values....

File src/libosmo-mgcp/mgcp_msg.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/a7aef3e8_dcc2a2f8?usp=... : PS4, Line 257: LOGP(DLMGCP, LOGL_NOTICE, "wrong MGCP option format: '%s'\n", line);

What i would like to see is that the parsing code returns error messages to the caller. […]

As already mentioned, I submitted a patch improving this at the end, so I guess it's fine now?

File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/01169e4e_cad6ee3e?usp=... : PS4, Line 846: case -523:

(you don't agree?)

I already changed this to be negative as requested by daniel, so no, I won't spend time changing it into positive values again. Feel free to spend your own time doing that after your patchset is merged if you think it's worth it.