Attention is currently required from: daniel, laforge, neels.

View Change

3 comments:

• File include/osmocom/mgcp/mgcp_protocol.h:

  • Patch Set #4, Line 7: #define MGCP_PARSE_HDR_PARS_OSMUX_CID_WILDCARD (-1)

    i disagree with that position. […]

    Neels, what are you talking about? You say you want me to add an enum with one or two fields and let aside the other 2^16 values? Or you want me to add 2^16 values to the enum?

    enums are meant for closed sets of values, not to cover int ranges with specific 2 values....

• File src/libosmo-mgcp/mgcp_msg.c:

  • Patch Set #4, Line 257: LOGP(DLMGCP, LOGL_NOTICE, "wrong MGCP option format: '%s'\n", line);

    What i would like to see is that the parsing code returns error messages to the caller. […]

    As already mentioned, I submitted a patch improving this at the end, so I guess it's fine now?

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #4, Line 846: case -523:

    (you don't agree?)

    I already changed this to be negative as requested by daniel, so no, I won't spend time changing it into positive values again. Feel free to spend your own time doing that after your patchset is merged if you think it's worth it.

To view, visit change 39224. To unsubscribe, or for help writing mail filters, visit settings.