osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39785?usp=email ) Change subject: gcc/Makefile: set shell: bash -o pipefail -e ...................................................................... gcc/Makefile: set shell: bash -o pipefail -e Don't ignore errors from commands piped into others, like in this line in the Makefile that has been added in aaec8734 ("add fw update crcstub"): printf $$CRC_HEX | xxd -r -p | xxd -e | xxd -r | dd of=$(OUTPUT_FILE_NAME)-dfu.bin bs=1 seek=$$CRC_CHECKSUM_OFFSET conv=notrunc 2>/dev/null; \ Change-Id: I9459f63828eab461607fa9f226716d32ae898549 --- M gcc/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/gcc/Makefile b/gcc/Makefile index 7813750..b5d3cf0 100644 --- a/gcc/Makefile +++ b/gcc/Makefile @@ -1,5 +1,5 @@ # possible values: SAME54_XPLAINED_PRO, SYSMOOCTSIM -SHELL := /bin/bash +SHELL := /bin/bash -o pipefail -e BOARD ?= SYSMOOCTSIM CROSSCC ?= arm-none-eabi- SILENT ?= @ -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I9459f63828eab461607fa9f226716d32ae898549 Gerrit-Change-Number: 39785 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>