Attention is currently required from: fixeria.
falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email )
Change subject: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind() ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Why not instead keep the call to csd_v110_rtp_decode() where it is [...]
I think we will need to pass TDMA Fn to `csd_v110_rtp_decode()` too, in order to ensure the correct ordering of the RLP frame halves for TCH/F4.8 NT. We loose bits E1/E2/E3 when calling `csd_v110_rtp_decode()` (they're not part of the modified Um V.110 frames), and thus we cannot ensure the alignment after that... Do you have a better idea?
I do have a better idea, and I am going to produce a series of patches implementing it. Please give me a little more time.