Change in osmo-msc[master]: SMPP: move read/write callbacks to libsmpputil - gerrit-log

15 Sep 2022


      Attention is currently required from: msuraev.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 )
Change subject: SMPP: move read/write callbacks to libsmpputil
......................................................................
Patch Set 28:
(1 comment)
File include/osmocom/smpp/smpp.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-msc-lint-361):
https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/7ef84a92_d318371e 
PS28, Line 57: #define OSMO_FD_CHECK_READ(rc, err_label) do {                                                 \
Macros with flow control statements should be avoided
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76
Gerrit-Change-Number: 28848
Gerrit-PatchSet: 28
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: msuraev msuraev@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Thu, 15 Sep 2022 03:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment