Attention is currently required from: csaba.sipos.

pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................

Patch Set 3:

(2 comments)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/127f96c9_9708fb48?usp=... : PS3, Line 617: { 0x01, "BCF" }, /* Base Control Function */ can we have defines or enum for all of these?

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/044694a7_6d4f9a6b?usp=... : PS3, Line 638: { 0x0, "Enabled" }, can we have defines or enum for all of these?

Plus, below you seem to use 0xff as "state invalid" or alike, so it probablyh makes sense to add that one to the defines/enums.