[S] Change in osmo-msc[master]: vlr: set the correct CN domain on GSUP messages - gerrit-log

15 Oct 2024

Attention is currently required from: laforge.

lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email )

Change subject: vlr: set the correct CN domain on GSUP messages
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4: 
...
  IMHO it makes more sense to have some kind of a
wrapper function, like vlr_gsup_client_mux_tx() whic […] Not all GSUP Messages has
it according to the hlr manual.
But I can add it via a function which sets it only when it has the correct message type.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1
Gerrit-Change-Number: 38406
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Tue, 15 Oct 2024 15:52:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;