Attention is currently required from: neels, laforge, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31618 )
Change subject: pcu_sock: handle multiple BTSs with one BSC co-located PCU (in theory) ......................................................................
Patch Set 10:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31618/comment/47142573_38c04008 PS10, Line 62: bool pcu_connected(struct gsm_bts *bts) imho this should be passed a net object now. This is the pcu_sock so no depending on any BTS. If you want, add an extra function in bts.c bts_is_pcu_connected(bts) to add the extra is_ericsson_bts() after calling this pcu_connected().
EDIT: actually, it probably needs to be passed a struct pcu_sock_state *stat. Either that or *net, whatever you feel like.