Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32169 )
Change subject: tests: rename and extend gprs_{bvci_default->params}.vty ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/32169/comment/29df5486_0a9158d3 PS1, Line 18: The PCU obviously cannot bind to port 0, and will keep re-starting.
It's actually a good question. […]
I think I know whats happening...
``` commit 315af2f9ea1e8b9bf6e58caebd9dd7829edecfed Author: Alexander Couzens lynxis@fe80.eu Date: Mon Dec 19 21:21:32 2022 +0100
bts: ipa/osmo-bts/sysmobts: MO: add support for the second NSVC ```
This commit added a function checking whether the given NSVC config is valid:
``` static bool has_valid_nsvc(struct gsm_gprs_nsvc *nsvc) { switch (nsvc->remote.u.sa.sa_family) { case AF_INET: case AF_INET6: return (nsvc->local_port > 0 && !osmo_sockaddr_is_any(&nsvc->remote)); default: return false; } } ```
Note that not only it check the remote address, but also the bind port. So if you have a valid remote address and the bind port set to 0, osmo-bsc would ignore this NSVC and leave it unconfigured in the BTS.