Attention is currently required from: osmith, pespin. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 1: Code-Review-1 Copied votes on follow-up patch sets have been updated: * Code-Review-1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN"). (1 comment) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39920/comment/cffe36ad_cf3fae09?… : PS1, Line 538: osmo_stream_cli_destroy(srvc->conn); Can you actually try the following? if (srvc->conn) { struct ... conn = srvc->conn; srvc->conn = NULL; osmo_stream_cli_destroy(conn); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes