Attention is currently required from: msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Add osmo_sockaddr_str_from_sockaddr2()
......................................................................
Patch Set 4: Code-Review-2
(1 comment)
Patchset:
PS4:
Ideally the existing function should have been passed a "struct sockaddr"
pointer, but it's not really an issue, a cast is expected there and that's totally
usual in this context.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Aug 2022 09:47:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment