Change in osmo-e1-hardware[master]: icE1usb fw: Vendor requests to other interface than 0 are not errors
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26834 )
Change subject: icE1usb fw: Vendor requests to other interface than 0 are not errors ......................................................................
icE1usb fw: Vendor requests to other interface than 0 are not errors
They might be used somewhere else ... just don't handle them, but let someone else potentially do it.
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: Ie1bce4565d14d6635d4a32c2a08f64728132a75e --- M firmware/ice40-riscv/icE1usb/usb_e1.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/34/26834/1
diff --git a/firmware/ice40-riscv/icE1usb/usb_e1.c b/firmware/ice40-riscv/icE1usb/usb_e1.c index 34ade71..09b428c 100644 --- a/firmware/ice40-riscv/icE1usb/usb_e1.c +++ b/firmware/ice40-riscv/icE1usb/usb_e1.c @@ -375,7 +375,7 @@ return _e1_ctrl_req_dev(req, xfer); case USB_REQ_RCPT_INTF: if (req->wIndex != 0) - return USB_FND_ERROR; + return USB_FND_CONTINUE; return _e1_ctrl_req_intf(req, xfer); case USB_REQ_RCPT_EP: case USB_REQ_RCPT_OTHER:
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26834 )
Change subject: icE1usb fw: Vendor requests to other interface than 0 are not errors ......................................................................
Patch Set 1: Code-Review+2
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26834 )
Change subject: icE1usb fw: Vendor requests to other interface than 0 are not errors ......................................................................
icE1usb fw: Vendor requests to other interface than 0 are not errors
They might be used somewhere else ... just don't handle them, but let someone else potentially do it.
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: Ie1bce4565d14d6635d4a32c2a08f64728132a75e --- M firmware/ice40-riscv/icE1usb/usb_e1.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/firmware/ice40-riscv/icE1usb/usb_e1.c b/firmware/ice40-riscv/icE1usb/usb_e1.c index 34ade71..09b428c 100644 --- a/firmware/ice40-riscv/icE1usb/usb_e1.c +++ b/firmware/ice40-riscv/icE1usb/usb_e1.c @@ -375,7 +375,7 @@ return _e1_ctrl_req_dev(req, xfer); case USB_REQ_RCPT_INTF: if (req->wIndex != 0) - return USB_FND_ERROR; + return USB_FND_CONTINUE; return _e1_ctrl_req_intf(req, xfer); case USB_REQ_RCPT_EP: case USB_REQ_RCPT_OTHER:
-
laforge -
tnt