Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email )

Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ......................................................................

Patch Set 3:

(32 comments)

File include/osmocom/vlr/vlr.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/aa8a34c5_13703fdb?usp... : PS3, Line 121: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order

File src/libvlr/vlr.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/0643cb63_ca3eb62d?usp... : PS3, Line 238: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f3a39909_c33dd9d1?usp... : PS3, Line 242: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/027afac8_218d2ac9?usp... : PS3, Line 246: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/4f347e26_0852688e?usp... : PS3, Line 258: char *name = (char*)vlr_subscr_name(vsub); "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c75796a4_ea78b07a?usp... : PS3, Line 263: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/37c3f19d_8a9553dd?usp... : PS3, Line 380: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6bdd6552_17288f3e?usp... : PS3, Line 705: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/888c406a_af9392a6?usp... : PS3, Line 810: struct sgsn_subscriber_pdp_data* pdata; "foo* bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/1055498a_11dcd003?usp... : PS3, Line 1447: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/94dbda20_8bf3339b?usp... : PS3, Line 1455: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/959307c3_14348149?usp... : PS3, Line 1457: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3782d421_fc58feeb?usp... : PS3, Line 1459: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3cae54e2_9e96164b?usp... : PS3, Line 1716: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo*)" should be "(foo *)"

File src/libvlr/vlr_access_req_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/67ad3e66_0f919e03?usp... : PS3, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/aa7cd5ff_59f7bd4c?usp... : PS3, Line 415: } else { else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/338ff269_5bfb3081?usp... : PS3, Line 421: } else { else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f4396d82_68750983?usp... : PS3, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2f5491b2_95371b58?usp... : PS3, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8c48054a_0c6a7a34?usp... : PS3, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE)

File src/libvlr/vlr_auth_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/bf79983d_dc0fd1dd?usp... : PS3, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f311b37f_7e00e20c?usp... : PS3, Line 216: } else { else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6f83cce7_6de1b338?usp... : PS3, Line 543: strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

File src/libvlr/vlr_lu_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/473cb8fa_1ddb183e?usp... : PS3, Line 160: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3144ab5e_b3116e65?usp... : PS3, Line 272: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3e753f0e_ddd076e4?usp... : PS3, Line 667: return (struct lu_compl_vlr_priv*)fi->priv; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/82b573ad_5b99fef3?usp... : PS3, Line 1282: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/60c8c61d_21d09351?usp... : PS3, Line 1404: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/aef33773_cdc0e270?usp... : PS3, Line 1436: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/248af589_6a5648c0?usp... : PS3, Line 1643: return (struct lu_fsm_priv*)fi->priv; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/621931ce_0218aee1?usp... : PS3, Line 1691: strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

File src/libvlr/vlr_sgs.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21559): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/965d1233_7f3c806b?usp... : PS3, Line 324: } void function return statements are not generally useful