pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email )
Change subject: osmo_io: Reorder iofd_handle_segmented_read() ......................................................................
osmo_io: Reorder iofd_handle_segmented_read()
All other similar functions have first the int rc and later the struct msgb; fix this one being different.
Change-Id: I88683334e77901776c806dad776ef46ea20b4480 --- M src/core/osmo_io.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 41730b4..bd4f468 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -359,7 +359,7 @@
/*! Restore message boundaries on read() and pass individual messages to the read callback */ -static void iofd_handle_segmented_read(struct osmo_io_fd *iofd, struct msgb *msg, int rc) +static void iofd_handle_segmented_read(struct osmo_io_fd *iofd, int rc, struct msgb *msg) { int res; struct msgb *pending; @@ -425,7 +425,7 @@ { switch (iofd->mode) { case OSMO_IO_FD_MODE_READ_WRITE: - iofd_handle_segmented_read(iofd, msg, rc); + iofd_handle_segmented_read(iofd, rc, msg); break; case OSMO_IO_FD_MODE_RECVFROM_SENDTO: talloc_steal(iofd->msgb_alloc.ctx, msg);