Attention is currently required from: arehbein, fixeria, jolly, laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email )
Change subject: osmo_io: SCTP support
......................................................................
Patch Set 7:
(1 comment)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/02a2f193_7dc49848
PS7, Line 340: iofd->mode == OSMO_IO_FD_MODE_SCTP_RECVMSG_SEND) {
If I understand correctly in https://gerrit.osmocom.org/c/libosmocore/+/35910
You don't use this code path (for SCTP) anymore, because it doesn't work? In that case just remove the code here.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I89eb519b22d21011d61a7855b2364bc3c295df82
Gerrit-Change-Number: 35068
Gerrit-PatchSet: 7
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein
arehbein@sysmocom.de
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: jolly
andreas@eversberg.eu
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: arehbein
arehbein@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 20 Feb 2024 08:49:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment