Attention is currently required from: pespin, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )
Change subject: Add hnbgw tests ......................................................................
Patch Set 2:
(7 comments)
Patchset:
PS1:
To me this looks good. I have the tests running already. […]
Yeah, you're right. I merged multiple patches into this one now.
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/f6990540_0d279... PS1, Line 212: /*function f_start_handler(void_fn fn, template (omit) TestHdlrParams pars := omit)
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a5aee836_6b61a... PS1, Line 218: /*private function f_tc_hnb_register_request(charstring id) runs on HNBGW_ConnHdlr {
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/e526a2a8_1dd0b... PS1, Line 224: //var HNBGW_ConnHdlr vc_conn;
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/211777cb_69421... PS1, Line 247: //var HNBGW_ConnHdlr vc_conn;
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a02d23a1_11d41... PS1, Line 267: //RANAP.receive();
Can this be dropped?
Done
File hnbgw/MSC_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/c3e85194_ccad1... PS1, Line 96: // FIXME
FIXME what?
Done
-
daniel