Attention is currently required from: pespin, dexter.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )
Change subject: Add hnbgw tests
......................................................................
Patch Set 2:
(7 comments)
Patchset:
PS1:
To me this looks good. I have the tests running
already. […]
Yeah, you're right.
I merged multiple patches into this one now.
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/f6990540_0d27…
PS1, Line 212: /*function f_start_handler(void_fn fn, template (omit) TestHdlrParams pars
:= omit)
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a5aee836_6b61…
PS1, Line 218: /*private function f_tc_hnb_register_request(charstring id) runs on
HNBGW_ConnHdlr {
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/e526a2a8_1dd0…
PS1, Line 224: //var HNBGW_ConnHdlr vc_conn;
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/211777cb_6942…
PS1, Line 247: //var HNBGW_ConnHdlr vc_conn;
Can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a02d23a1_11d4…
PS1, Line 267: //RANAP.receive();
Can this be dropped?
Done
File hnbgw/MSC_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/c3e85194_ccad…
PS1, Line 96: // FIXME
FIXME what?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a2fb795aec83337eda8d9972e6ff264ead61076
Gerrit-Change-Number: 27106
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Feb 2022 14:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment