Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/33398
)
Change subject: msc_ho_send_handover_request: fix check_after_deref
......................................................................
Patch Set 1:
(1 comment)
File src/libmsc/msc_ho.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33398/comment/caa823f9_450504fe
PS1, Line 424: ran_enc_msg.handover_request.geran.channel_type = &channel_type;
imho you should move setting those 2 fields to here
(or in line 418).
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/33398
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9
Gerrit-Change-Number: 33398
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Jun 2023 12:53:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment