Attention is currently required from: dexter, fixeria, laforge.

Hello Jenkins Builder, fixeria, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/41450?usp=email

to look at the new patch set (#6).

The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder

Change subject: card_key_provider: separate and refactor CSV column encryption ......................................................................

card_key_provider: separate and refactor CSV column encryption

The CardKeyProviderCsv class implements a column decryption scheme where columns are protected using a transport key. The CSV files are enrcypted using contrib/csv-encrypt-columns.py.

The current implementation has two main problems:

- The decryption code in CardKeyProviderCsv is not specific to CSV files. It could be re-used in other formats, for example to decrypt columns (fields) red from a database. So let's split the decryption code in a separate class.

- The encryption code in csv-encrypt-columns.py accesses methods and properties in CardKeyProviderCsv. Also having the coresponding encryption code somewhere out of tree may be confusing. Let's improve the design and put encryption and decryption functions in a single class. Let's also make sure the encryption/decryption is covered by unittests.

Related: SYS#7725 Change-Id: I180457d4938f526d227c81020e4e03c6b3a57dab --- M contrib/csv-encrypt-columns.py M pySim/card_key_provider.py M tests/unittests/test_card_key_provider.py 3 files changed, 165 insertions(+), 60 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/41450/6